Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] avoid doble upscaling in inpaint #14966

Conversation

light-and-ray
Copy link
Contributor

@light-and-ray light-and-ray commented Feb 19, 2024

Description

Since upscaler progressbar appeared, I've noticed image is upscaled two times for inpainting if upscaler_for_img2img is overridden. I debugged with console log, and Image.show(), they are exactly the same images and exactly the same target resolution. It happens because of saving original_denoised_image outside apply_overlay function

Reproduce:

  1. Override upscaler for img2img
  2. Inpaint area = Only masked
  3. Inpaint area that bigger then 512x512 in 512x512 resolution
  4. See in console two upscales

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 0a27193 into AUTOMATIC1111:dev Feb 19, 2024
3 checks passed
AUTOMATIC1111 added a commit that referenced this pull request Feb 20, 2024
…_inpaint

[bug] avoid doble upscaling in inpaint
@light-and-ray light-and-ray deleted the avoid_doble_upscaling_in_inpaint branch February 20, 2024 13:37
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants