Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option "open image button" open the actual dir #14947

Merged
merged 2 commits into from Feb 17, 2024
Merged

option "open image button" open the actual dir #14947

merged 2 commits into from Feb 17, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Feb 17, 2024

Description

one of the things that annoys me no end is that the open image button don't actually opens the actual output dir but the output root
image
this is annoying for people that uses subdirectories, this is one extra click for every time they use open image button
also since we would navigate in the the suvdir the next time we click the button it opens a new windwos causing lots of extra windows to be open

this PR makes it so it will to open the actual directory and not output root

I decided to enable this option by default because I feel like it's more natural option

this also would be useful if one has images up to different directories (such as the grid images)

user can select which directory to open
image

  • Output root will always open the main output root (effectively disabling this PR)
  • Subdirectory will open the the actual directory
  • Subdirectory (even temp dir) same as Subdirectory but will also open the temp dir (when image is not always saved)

if possible I like to squeeze this into 1.8 RC

Checklist:

@AUTOMATIC1111
Copy link
Owner

We will fit it into 1.8 but are settings necessary? Seems like a good change that doesn't need any configuration.

@w-e-w
Copy link
Collaborator Author

w-e-w commented Feb 17, 2024

Seems like a good change that doesn't need any configuration.

that's why I enabled it by default
but I think in some cases someone might prefer the old behavior
since adding a setting allows people to go use the old behavior at nearly no cost, so it's more of a why not provide an option

I don't really like the wording of my settings descriptions if you have suggestions

@AUTOMATIC1111 AUTOMATIC1111 merged commit 9d5becb into dev Feb 17, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the open-button branch February 17, 2024 18:30
AUTOMATIC1111 added a commit that referenced this pull request Feb 17, 2024
option "open image button" open the actual dir
@w-e-w w-e-w mentioned this pull request Feb 18, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants