Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle 0 wheel deltaY #15268

Merged

Conversation

light-and-ray
Copy link
Contributor

@light-and-ray light-and-ray commented Mar 15, 2024

Description

I had a strange bug. When I was scrolling on remote PC via VNC remote desktop, I wasn't able to zoom out. I've found it's because deltaX was always 0. If I do it with real mouse - everything is OK

It's not really necessary to fix it in this way, this bug is rare and it's a problem of VNC. But I think nothing will be wrong with this change

Checklist:

@light-and-ray light-and-ray changed the title handle 0 wheel deltaX handle 0 wheel deltaY Mar 15, 2024
@AUTOMATIC1111
Copy link
Owner

Any comment from @daswer123? Also could this be written in one line, something like (e.deltaY || -e.wheelDelta)?

@light-and-ray
Copy link
Contributor Author

pushed

@AUTOMATIC1111 AUTOMATIC1111 merged commit 874809e into AUTOMATIC1111:dev Mar 16, 2024
3 checks passed
@light-and-ray light-and-ray deleted the handle_0_wheel_deltaX branch March 17, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants