Automatically Set the Scale by value when user selects an Upscale Model #15244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haoming02
changed the title
|
this behavior is controversial some might find it useful others might find it annoying, there must be an option to toggle this behavior
while that may be true for modues downloaded from OpenModelDB, but I think none of the models we provide by default follow this pattern, I think the match pattern should be more general |
|
I agree with w-e-w. The intent behind this PR makes sense, but frankly most users aren't going to care what upscale factor the model was trained on, and are going to want to upscale an image by the factor they desire. |
Now supports all natively provided upscaler as well
Now this is disabled by default
AUTOMATIC1111
approved these changes
Mar 16, 2024
AUTOMATIC1111
added a commit
that referenced
this pull request
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edited
What you're trying to accomplish
Since the majority of the upscale models are named with its scaling factor (eg.
4x-UltraSharporDAT x2), this PR makes it automatically set the appropriateScale byvalue when user selects a model with that pattern.A summary of changes in code
When setting up the UI, add a function that utilizes the
gradioinputmethod to check for the above condition viare, then set the value if possible. This feature is toggleable in the Settings.Checklist: